Handle QLineEdit focus object correctly with QCompleter in Qt6 #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qt6, when using QLineEdit with QCompleter during Chinese input: - qGuiApp->focusObject() and realFocusObject are both QLineEdit - This is logically correct as the focus is indeed on QLineEdit - However, it caused filterEvent to return false and trigger unwanted keypress events - Remove redundant check to ensure proper input method handling This fixes input method behavior when using QLineEdit with QCompleter in Qt6, especially for Chinese input scenarios.
|
This is actually due to qt fix the original https://bugreports.qt.io/browse/QTBUG-108522 Now focusObject is correct, however, focusWindow won't adapt to relevant changes. I think it somehow makes sense since focusWindow has some other meanings. But we still want to have the window associated with focusObject. I think the change here actually make sense, when focusObject is a QWidget, always use the QWindow of the widget. |
wyu71
added a commit
to wyu71/fcitx5-qt-community
that referenced
this pull request
Jun 18, 2025
In Qt6, when using QLineEdit with QCompleter during Chinese input: - qGuiApp->focusObject() and realFocusObject are both QLineEdit - This is logically correct as the focus is indeed on QLineEdit - However, it caused filterEvent to return false and trigger unwanted keypress events - Remove redundant check to ensure proper input method handling Log: Handle QLineEdit focus object correctly with QCompleter in Qt6 Upstream: fcitx/fcitx5-qt#71
Zeno-sole
pushed a commit
to deepin-community/fcitx5-qt
that referenced
this pull request
Jun 18, 2025
In Qt6, when using QLineEdit with QCompleter during Chinese input: - qGuiApp->focusObject() and realFocusObject are both QLineEdit - This is logically correct as the focus is indeed on QLineEdit - However, it caused filterEvent to return false and trigger unwanted keypress events - Remove redundant check to ensure proper input method handling Log: Handle QLineEdit focus object correctly with QCompleter in Qt6 Upstream: fcitx/fcitx5-qt#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Qt6, when using QLineEdit with QCompleter during Chinese input:
This fixes input method behavior when using QLineEdit with QCompleter in Qt6, especially for Chinese input scenarios.